Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for glob pattern matching in Host directives #306

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Add support for glob pattern matching in Host directives #306

merged 2 commits into from
Jul 4, 2024

Conversation

packetsource
Copy link
Contributor

  • update parse logic to perform host glob matching (using globset)
  • generalise token expansion so it can be used to qualify hosts as well as localising ProxyCommand
  • add proxyjump to the config structure

- generalise token expansion so it can be used to qualify hosts as well as localising ProxyCommand
- add proxyjump to the config structure
@Eugeny Eugeny merged commit 1eaadfb into Eugeny:main Jul 4, 2024
4 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Jul 4, 2024

Thank you!

@all-contributors please add @packetsource for code

Copy link
Contributor

@Eugeny

I've put up a pull request to add @packetsource! 🎉

Eugeny pushed a commit that referenced this pull request Jul 4, 2024
Adds @packetsource as a contributor for code.

This was requested by Eugeny [in this
comment](#306 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Eugeny pushed a commit that referenced this pull request Aug 24, 2024
PR #306 broke russh config parsing
for me.

My ssh config looks roughly like this:

```
Host *
    Common settings
Host wanted
   Host-specific settings
```

Before #306 common settings were
ignored, but after - common settings were applied, yet config parser
stops right on next `Host` section start, so settings I need were
ignored instead.

This PR brings behavior closer to what openssh itself does - for
requested host, it applies all the settings with maching glob, not only
the first one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants